Stop using deprecated Hooks::isDisambiguationPage() method #139
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is being removed from Extension:Disambiguator in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Disambiguator/+/995218
lens0021
approved these changes
Feb 2, 2024
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-Disambiguator
that referenced
this pull request
Feb 7, 2024
The only production user of the deprecated Hooks::isDisambiguationPage() method is the RelatedArticles extension; the 'depends-on' patch here tweaks it to use the DisambiguatorLookup service instead. A similar patch to fix up a 3rd-party extension is at: femiwiki/UnifiedExtensionForFemiwiki#139 This continues the slow cleanup moving to injected services from globals. Depends-On: Id2a10f2f1be0e38ddb8ebef5d5babb3daac3ce9a Change-Id: I7f74c0c6347e7c5fea10c49aef665558762711d0
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions
that referenced
this pull request
Feb 7, 2024
* Update Disambiguator from branch 'master'
to 8147701f1a287b4a4302b42e4d09c6b3510aace6
- Merge "Use injected Lookup service; remove deprecated method"
- Use injected Lookup service; remove deprecated method
The only production user of the deprecated
Hooks::isDisambiguationPage() method is the RelatedArticles extension;
the 'depends-on' patch here tweaks it to use the DisambiguatorLookup
service instead.
A similar patch to fix up a 3rd-party extension is at:
femiwiki/UnifiedExtensionForFemiwiki#139
This continues the slow cleanup moving to injected services from
globals.
Depends-On: Id2a10f2f1be0e38ddb8ebef5d5babb3daac3ce9a
Change-Id: I7f74c0c6347e7c5fea10c49aef665558762711d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is being removed from Extension:Disambiguator in
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Disambiguator/+/995218